-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize browser processes rather than pages #50
Conversation
@tsuyoshiwada I also want to parallelize the PREPARE phase. But I do not know when I do it 😅 If I would do this, I open another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! It works very fast! Thx 🙏
I only commented on one point so I'm happy if you can check it 😃
@@ -1,7 +1,6 @@ | |||
import * as puppeteer from 'puppeteer'; | |||
import { EventTypes } from '../constants'; | |||
import { CLIOptions } from '../../models/options'; | |||
import { createArray } from '../utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since createArray
is unnecessary, it may be better to delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐶 ✨
Hi @Quramy, Thank you for contribute!! |
I've created this for #7 :)
This PR makes parallelization in the
CAPTURE
phase more efficient. It because that considering TCP connection restrictions of Chromium, parallelization of browser processes can use CPU more efficiently than parallelization of pages in one browser process.