Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Registry: Replace numeric Agent.id with PK #108

Merged
merged 7 commits into from
Jun 28, 2019

Conversation

jcowman2
Copy link
Contributor

Description

  • Changes Agent.id from being a number to being a PK<Agent>.
  • Adds a few methods to PK and PKProvider.

Checklist

Change Type

  • Bug Fix
  • New Feature
  • Refactor (changes code but not behavior)
  • Non-code Change (documentation, dependencies, etc.)

Is this a breaking change?

  • No
  • Yes

If yes, describe what exactly this change breaks:

Agent.id is no longer a number. It is now a PK<Agent>. This doesn't change any external behavior, but since Agent.id is part of the public API, it is technically breaking.

Unit Tests

  • Tests Added
  • Tests Modified
  • No Change

Documentation

  • In-code Docs
  • API Reference
  • Other (Specify: )
  • No Change

Related Issues

Issue Number Action Notes
#104 Partially Implemented

Further Action

Description Issue Number
Use the PK system in the remaining indexed classes #104
Update API reference to reflect prototype registry changes #105

@jcowman2 jcowman2 added this to the Iteration 1 milestone Jun 28, 2019
@jcowman2 jcowman2 merged commit 0e3a42a into stage Jun 28, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 318

  • 85 of 85 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 313: 0.0%
Covered Lines: 981
Relevant Lines: 981

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants