New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype Registry: Replace numeric RandomRecord.id with PK<RandomRecord> #111

Merged

jcowman2 merged 2 commits into stage from feat-104/prototype-registry

Jul 23, 2019

Contributor

jcowman2 commented Jul 23, 2019

Description

Changes RandomRecord.id from being a number to being a PK<RandomRecord>.
Adds a few methods to PKProvider.

Checklist

Change Type

Bug Fix
New Feature
Refactor (changes code but not behavior)
Non-code Change (documentation, dependencies, etc.)

Is this a breaking change?

No
Yes

If yes, describe what exactly this change breaks:

Unit Tests

Tests Added
Tests Modified
No Change

Documentation

In-code Docs
API Reference
Other (Specify: )
No Change

Related Issues

Issue Number	Action	Notes
#104	Partially Implemented

Further Action

Description	Issue Number
Move on to the next phase -- Agent metadata restructuring	#104
Update API reference to reflect prototype registry changes	#105


          refactor(random): Replace numeric RandomRecord.id with PK<RandomRecord>

7f005a7

re #104

jcowman2 added this to the Iteration 1 milestone

jcowman2 changed the base branch from master to stage

July 23, 2019 01:49


          docs: Minor fix

84bac49

jcowman2 merged commit fa3f6e3 into stage

coveralls commented Jul 23, 2019

Pull Request Test Coverage Report for Build 336

16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 334:	0.0%
Covered Lines:	993
Relevant Lines:	993

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment