Using runtime/debug for git version details #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the embed/version.json and associated calls. Breaking: tag details are no longer available. Breaking: regclient.VCSRef and VCSTag variables removed. Breaking: detailed version support removed for Go 1.17 and earlier. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Mitchell git@bmitch.net
Fixes issue
Fixes #304
Describe the change
This removes the
embed/version.jsonand associated calls, replacing withruntime/debugcalls.How to verify it
Changelog text
Breaking: tag details are no longer available in version commands.
Breaking:
regclient.VCSRefandVCSTagvariables removed.Breaking: detailed version support removed for Go 1.17 and earlier.
Please verify and check that the pull request fulfills the following requirements