Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Python 3.12 #104

Open
mweinelt opened this issue Dec 4, 2023 · 0 comments
Open

Incompatible with Python 3.12 #104

mweinelt opened this issue Dec 4, 2023 · 0 comments

Comments

@mweinelt
Copy link

mweinelt commented Dec 4, 2023

We are moving towards Python 3.12 over in nixpkgs, and noticed this package relies somewhat heavily on distutils, which has been deprecated since 3.10, see https://peps.python.org/pep-0632/.

Now I see that master recently started testing against 3.12, but I don't understand how that succeeds. For me, it fails like this on 4.2:

 ======================================================================
 ERROR: pyroma (unittest.loader._FailedTest.pyroma)
 ----------------------------------------------------------------------
 ImportError: Failed to import test module: pyroma
 Traceback (most recent call last):
   File "/nix/store/ly93xq4pckid6ykivk07ln04bgjf41hv-python3-3.12.0/lib/python3.12/unittest/loader.py", line 129, in loadTestsFromName
     module = __import__(module_name)
              ^^^^^^^^^^^^^^^^^^^^^^^
   File "/build/source/pyroma/__init__.py", line 4, in <module>
     from pyroma import projectdata, distributiondata, pypidata, ratings
   File "/build/source/pyroma/projectdata.py", line 8, in <module>
     from distutils import core
 ModuleNotFoundError: No module named 'distutils'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant