Add a warning for the deprecated test_suit
#74
Conversation
| return "test_suite" not in data | ||
|
|
||
| def message(self): | ||
| return "The `setup.py test` command and accompanying `test_suit` field has been deprecated." |
There was a problem hiding this comment.
I'm not sure why this typo is everywhere, but the term and corresponding option is test_suite, not test_suit 😆
There was a problem hiding this comment.
facepalm
Edit: phew I only made that mistake there. So I won't fix it, as the test is pointless in the 4x branch anyway. :-)
There was a problem hiding this comment.
phew I only made that mistake there. It gets to stay, as the test in pointless in the 4x branch...
| weight = 50 | ||
|
|
||
| def test(self, data): | ||
| return "test_suite" not in data |
There was a problem hiding this comment.
FYI, this check doesn't actually work, since as mentioned on #72 , this is a Setuptools-specific option (under the [options] section in setup.cfg, or the [tool.setuptools] table in pyproject.toml), not anything in the standardized core metadata like everything else you check here.
There was a problem hiding this comment.
Yes, right, it only works when the metadata is fetched by patching setuptools. So it's useful in Pyroma 3 (which this was) but for Pyroma 4 it's pointless, true. So I can already remove it again. :-)
No description provided.