Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): move params within params #1635

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

ryanchristo
Copy link
Member

Description

Ref: #1456 (https://hackmd.io/vcNbk99BTiWJ4cMtALSBOA?view)

While manual testing, I noticed the two new params returned in QueryParams were being returned outside the other params. This seemed a bit odd and confusing so this pull request moves them within the Params struct with the others. The changes are part of the current revision so no breaking proto changes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review November 23, 2022 20:12
@ryanchristo ryanchristo requested a review from a team November 23, 2022 20:12
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1635 (70c1fd5) into main (6043274) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 70c1fd5 differs from pull request most recent head 334fe02. Consider uploading reports for the commit 334fe02 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
+ Coverage   77.62%   77.64%   +0.01%     
==========================================
  Files         266      266              
  Lines       19484    19501      +17     
==========================================
+ Hits        15125    15142      +17     
  Misses       3490     3490              
  Partials      869      869              
Impacted Files Coverage Δ
x/ecocredit/base/keeper/query_params.go 56.00% <100.00%> (ø)
x/ecocredit/client/testsuite/query.go 99.53% <100.00%> (+<0.01%) ⬆️
x/ecocredit/client/testsuite/suite.go 96.47% <100.00%> (+0.06%) ⬆️

@ryanchristo ryanchristo merged commit 9234a39 into main Nov 24, 2022
@ryanchristo ryanchristo deleted the ryan/refactor-params branch November 24, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants