Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create x/curation module data model and tx API #395

Closed
wants to merge 1 commit into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 18, 2021

ref: #374

I had some ideas in my head on this so wanted to get them down. This proposes an API for the x/curation module as proposed in #374.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #395 (d7d2802) into master (6f3b83b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files          51       51           
  Lines        3317     3317           
=======================================
  Hits         2024     2024           
  Misses       1029     1029           
  Partials      264      264           
Flag Coverage Δ
experimental-codecov 61.01% <ø> (ø)
stable-codecov 61.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable API to me.

Do we want to be able to delete a tag/tagset as well?

Also a quick question on naming - some places the messages are name with Request and some places they're not. Do we have a consistent guideline for that?

@aaronc
Copy link
Member Author

aaronc commented Jun 29, 2021

Do we want to be able to delete a tag/tagset as well?

Likely not, I think.

Also a quick question on naming - some places the messages are name with Request and some places they're not. Do we have a consistent guideline for that?

Remove Request is now the convention.


message MsgTagAssetClassResponse { }

message MsgEditTagSetMetadata {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we only want to edit one field (eg name)? Should we just have the rest of the fields set with their current values?

@aaronc
Copy link
Member Author

aaronc commented Oct 29, 2021

Closed in favor of #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants