-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create x/curation module data model and tx API #395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 51 51
Lines 3317 3317
=======================================
Hits 2024 2024
Misses 1029 1029
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable API to me.
Do we want to be able to delete a tag/tagset as well?
Also a quick question on naming - some places the messages are name with Request
and some places they're not. Do we have a consistent guideline for that?
Likely not, I think.
Remove |
|
||
message MsgTagAssetClassResponse { } | ||
|
||
message MsgEditTagSetMetadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we only want to edit one field (eg name)? Should we just have the rest of the fields set with their current values?
Closed in favor of #609 |
ref: #374
I had some ideas in my head on this so wanted to get them down. This proposes an API for the
x/curation
module as proposed in #374.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change