-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jared/mailerlite section #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a small bit of tweaking. I think the image could be repositioned a bit, and the spacing between the text. But I would like to merge it for the moment anyway if thats okay.
Also, I ended up using the static folder for the mailerlite javascript snippet, as I wasn't able to get it to work as an imported javascript file...but maybe there's something simple I'm missing if either of you would rather avoid the static folder?
Ahh, the other thing I'm going to try setting this up with a markdown content source. But that is for tomorrow.
Maybe a cleaner option would be just to call mailerlite API https://developers.mailerlite.com/reference#add-single-subscriber
It looks like we can still style the Thankyou message. We probably could overwrite the HTML too if need be. |
The last commit includes updates to move mailerlite credentials over to environmental variable, just forgot to title it. How do we look @blushi ? |
Should we merge this one @blushi ? |
This needs a small bit of tweaking. I think the image could be repositioned a bit, and the spacing between the text. But I would like to merge it for the moment anyway if thats okay.
Also, I ended up using the static folder for the mailerlite javascript snippet, as I wasn't able to get it to work as an imported javascript file...but maybe there's something simple I'm missing if either of you would rather avoid the static folder?
Ahh, the other thing I'm going to try setting this up with a markdown content source. But that is for tomorrow.