Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jared/mailerlite section #17

Merged
merged 9 commits into from
Jun 15, 2020
Merged

Jared/mailerlite section #17

merged 9 commits into from
Jun 15, 2020

Conversation

ratacat
Copy link
Contributor

@ratacat ratacat commented Jun 2, 2020

This needs a small bit of tweaking. I think the image could be repositioned a bit, and the spacing between the text. But I would like to merge it for the moment anyway if thats okay.

Also, I ended up using the static folder for the mailerlite javascript snippet, as I wasn't able to get it to work as an imported javascript file...but maybe there's something simple I'm missing if either of you would rather avoid the static folder?

Ahh, the other thing I'm going to try setting this up with a markdown content source. But that is for tomorrow.

@ratacat ratacat requested review from clevinson and blushi June 2, 2020 19:04
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a small bit of tweaking. I think the image could be repositioned a bit, and the spacing between the text. But I would like to merge it for the moment anyway if thats okay.

Also, I ended up using the static folder for the mailerlite javascript snippet, as I wasn't able to get it to work as an imported javascript file...but maybe there's something simple I'm missing if either of you would rather avoid the static folder?

Ahh, the other thing I'm going to try setting this up with a markdown content source. But that is for tomorrow.

Maybe a cleaner option would be just to call mailerlite API https://developers.mailerlite.com/reference#add-single-subscriber

web-www/src/pages/index.tsx Outdated Show resolved Hide resolved
web-www/src/components/mailSubmit.tsx Outdated Show resolved Hide resolved
@ratacat
Copy link
Contributor Author

ratacat commented Jun 3, 2020

It looks like we can still style the Thankyou message. We probably could overwrite the HTML too if need be.

@ratacat
Copy link
Contributor Author

ratacat commented Jun 3, 2020

The last commit includes updates to move mailerlite credentials over to environmental variable, just forgot to title it. How do we look @blushi ?

@regen-network regen-network deleted a comment from ratacat Jun 8, 2020
@ratacat
Copy link
Contributor Author

ratacat commented Jun 9, 2020

Should we merge this one @blushi ?

web-www/src/components/mailSubmit.tsx Outdated Show resolved Hide resolved
web-www/static/mailerlite.js Show resolved Hide resolved
@blushi blushi self-requested a review June 12, 2020 15:09
@ratacat ratacat merged commit 2b889f3 into master Jun 15, 2020
@ratacat ratacat deleted the jared/mailerlite branch June 15, 2020 15:59
@blushi blushi linked an issue Jun 19, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement shared Mailerlite section
2 participants