[BLU-3626] replace start value of i when Regen Address is verified #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezerrablockchain
force-pushed
the
BLU-3626-gasOptimization
branch
from
99a4696
to
063a34e
Compare
bezerrablockchain
changed the title
0xmichalis
reviewed
Feb 4, 2023
| require(prefix[i] == account[i], "regen address must start with 'regen1'"); | ||
|
|
||
| // verification: check address contains only alphanumeric characters | ||
| for (uint8 i = 6; i < accountLen; ++i) { |
There was a problem hiding this comment.
nit: isn't it actually cheaper to use uint256 here and in the loop above instead of uint8? It'd be great to run these over gas-reporter.
There was a problem hiding this comment.
I conducted a small tests using remix and it seems that in newer compiler version using small sized types are using less gas. But I am running same test using gas-reporter as well
0xmichalis
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace for (uint64 i = 0; i < accountLen; i++) { with for (uint64 i = 6; i < accountLen; i++; Also added unchecked to reduce a bit more gas consumption