Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtd: test don't use %matplotlib inline #495

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Nov 3, 2023

Sometimes rtd times out in the first cell of the method.ipynb notebook, which does:

%matplotlib inline

from matplotlib import rcParams

rcParams["figure.dpi"] = 300
rcParams["font.size"] = 8

import warnings

warnings.filterwarnings("ignore")

I'll to see if not having %matplotlib inline is faster. But as this is flaky behavior, we will probably not find out right now...

@mathause mathause changed the title rtd: test don't use %matplotlib inline rtd: test don't use %matplotlib inline Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #495 (2f9d8e5) into main (b4f87d8) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   98.79%   98.64%   -0.16%     
==========================================
  Files          17       17              
  Lines        1330     1330              
==========================================
- Hits         1314     1312       -2     
- Misses         16       18       +2     
Flag Coverage Δ
bare-minimum ?
min-all-deps 96.53% <ø> (ø)
shapely_lt_2 95.18% <ø> (ø)
unittests 98.64% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@mathause mathause merged commit 322ddb7 into regionmask:main Nov 3, 2023
9 of 10 checks passed
@mathause mathause deleted the rtd_test_not_use_mpl_inline branch November 3, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant