Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartopy: FeatureArtist is now a collection #525

Merged
merged 3 commits into from Mar 24, 2024

Conversation

mathause
Copy link
Member

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including whats-new.rst

@mathause mathause added the run-upstream run upstream-dev ci label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (e74cb22) to head (e27c8b5).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   99.79%   99.71%   -0.08%     
==========================================
  Files          17       17              
  Lines        1435     1407      -28     
==========================================
- Hits         1432     1403      -29     
- Misses          3        4       +1     
Flag Coverage Δ
bare-minimum ?
min-all-deps ?
shapely_lt_2 ?
unittests 99.71% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause closed this Mar 22, 2024
@mathause mathause reopened this Mar 22, 2024
@mathause
Copy link
Member Author

The remaining failures are unrelated to cartopy - they seem a matplotlib - numpy v2 incompatability

@mathause mathause merged commit 90325f2 into regionmask:main Mar 24, 2024
8 of 18 checks passed
@mathause mathause deleted the cartopy_feature_collection branch March 24, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-upstream run upstream-dev ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant