Add flag to see uncompleted tasks

[pmahnke]

The current version shows all completed and uncompleted tasks. To remove one from the view you need to delete it; however, that means losing history.

I think it would be better to just show --uncompleted tasks, so it would hide completed tasks from the view, but allow you to maintain your history if you wanted to review them.

Note, the completed task only disappears on after you quit and relaunch.

[cheginit]

Thanks for the PR!

I agree with showing uncompleted tasks in the bar but I am not sure if it's useful when launching (the button section) it.

[kgilmer]

Right, if completed tasks are hidden by default then isn't that the same as deleting?

[pmahnke]

@kgilmer if the only way you interact with td is from the bar, then yes, but if you use it in other ways on your system, you could look at completed todos for reference. By using the --uncompleted flag, it would work the same as it currently does but give you a history if you wanted.

[pmahnke]

I should also say I have filed an issue to have td add a toggle between completed/uncompleted in the interactive mode, which has been accepted - darrikonn/td-cli#20

[cheginit]

I made a few adjustments but for some reason the icon doesn't render properly:

@kgilmer, do you havey any idea why's that?
This is the output when I run the script:

I use the same font for the bar in my Xresource file:

[kgilmer]

When I copy/paste the default character from your diff in the script into gucharmap I get the same thing[1], when I go back to what's on master I get this[2], so seems like the character has changed in this branch..?

1:

2:

[kgilmer]

Regarding the visibility of completed tasks in the overlay, if you guys think that's the most generally useful treatment for the bar-driven UI, fine by me!

[cheginit]

Regarding the task, I would suggest to add a resource key so the user can specify it. Let the default be what it's now and add a flag like this:

i3xrocks.todo.uncompleted: true

Regarding the character this is the one that I am using:
https://fontawesome.com/icons/list-ol?style=solid

I just copy/pasted it again but still, the same issue.

[cheginit]

Ok, found the correct character.

[kgilmer]

@cheginit and @pmahnke are we good to go here or more work remaining?

[cheginit]

It's ready to be merged in my opinion.

[pmahnke]

Agreed. Ready to be merged.

[kgilmer]

Excellent and happy holidays @cheginit and @pmahnke !