-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid arch migrator PRs to maintenance branches that already have the arches #2500
Comments
This might be a bug related to the latest rerendering changes |
Thanks for the quick response! I only see permission-related bits in #2503 though, so I think that'll likely only cover the corner case mentioned in the OP (empty diff, presumably nonempty permission changes). However, as soon as the creation of a maintenance branch causes any kind of rerendering change (which is very often the case, as the old state of the feedstock at which we branch is not often 100% up to date), it'll still causes new arch PRs. Since the arch migrations are special anyway, I'd really like to avoid that case - e.g. we could check if there are already osx-arm64 files under In general, we could probably improve the situation around spurious PRs for all migrations (if we can spend the compute resources to rerender twice) as follows:
|
Two rerenders will slow the bot down a ton and so is not feasible at the moment. |
That's what I expected, but detecting files in |
I thought the bot opened these just if there's non-empty diff, but it turns out it'll even open a PR for a completely empty diff, c.f. conda-forge/openjdk-feedstock#160 / conda-forge/openjdk-feedstock#161
On feedstocks where we regularly need to create new branches for LTS versions, this becomes annoying eventually (aside from wasting CI resources). It can also create confusion for people who deal with this less frequently
The text was updated successfully, but these errors were encountered: