Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContactSubmission model and use it to ContactMixin submissions. #30

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

solarissmoke
Copy link
Member

There is one decision here which is possibly contentious - whether to do this in the view or the form.

Copy link

@craigloftus craigloftus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a particular problem with this approach, but I think I would have done it in the form save method. What was your rational for doing otherwise?

You do need to specify the postgres version .travis.yml to get the build to pass.

addons:
  postgresql: "9.6"

@solarissmoke
Copy link
Member Author

See comment here: https://github.com/regulusweb/wagtail-extensions/pull/30/files#diff-3cbffe09025c1312b8bb0d98ce858d02R37

The idea was that even if a project is using it's own form class it can still have the data saved without having to modify the corresponding form logic.

@solarissmoke solarissmoke force-pushed the feature/store-contact-submissions branch 2 times, most recently from 55a5518 to 3ba255a Compare April 17, 2018 11:37
@solarissmoke solarissmoke force-pushed the feature/store-contact-submissions branch from 3ba255a to 8fcbe35 Compare April 17, 2018 11:51
@solarissmoke solarissmoke merged commit d349687 into master Apr 17, 2018
@solarissmoke solarissmoke deleted the feature/store-contact-submissions branch April 17, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants