Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from Travis CI to Voxpupuli Github Actions. #43

Merged
merged 1 commit into from Jan 19, 2024

Conversation

bschonec
Copy link
Contributor

@bschonec bschonec commented Jan 19, 2024

Here are [what I think are] the bare minimum changes necessary to migrate off of Travis CI. I've removed a lot of stuff out of the Gemfile.

The spec tests do run successfully but because I don't know anything about Travis CI and know very little about Github Actions/Voxpupuli workflows I can't guarantee that all of the tests you expect to run are in fact running.

A few things I did:

  • Remove Puppet 6 tests
  • Added class parameter documentation just to quiet down the checker. That'll have to be addressed in another pull request.
  • Commented out some disabled test in the Rakefile
  • Fixed spacing/linting issues in manifests

No changes from other pull requests are included in this pull request.

@bschonec bschonec force-pushed the convert_to_github_actions branch 2 times, most recently from fbf80fb to 833501f Compare January 19, 2024 14:26
@rehanone
Copy link
Owner

Well I guess we should start with this PR and see what needs to be fixed after the GHA pipeline is working. Please let me know if this is ready and I will merge it. Thanks a lot once again for this amazing effort!

@bschonec
Copy link
Contributor Author

I think it's ready for merging albeit with a possibility of some tests no longer being performed. Again, my inexperience with Travis and CI/CD in general causes me to make that statement.

If you do merge it, then I can modify #37 so that it runs and tests properly.

@bschonec
Copy link
Contributor Author

Also, can you please enable github actions for this project? My GHA pipeline runs fine but I think you'll need to enable actions for your project.

@rehanone rehanone merged commit 0bd4581 into rehanone:master Jan 19, 2024
@rehanone
Copy link
Owner

I had to make a little change for the actions trigger but it looks like the tests are working, at least the unit test. Not sure about the integration tests though. Looks like they might be missing.

@bschonec
Copy link
Contributor Author

Probably. I'm just starting my journey here. Can you point me to where the integrations tests USED TO be? I assume in the .travis-ci.yaml file but if you can confirm where they were located I'll try to move them, too.

@rehanone
Copy link
Owner

All Integration tests are in /spec/acceptance/class_spec.rb. They dont have much coverage but they used to run /examples/init.pp file on various OS docker images. This was helpful to spot any changes happening in new OS releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants