Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codefix): create component signature interface for TOC #1278

Merged
merged 9 commits into from
Oct 2, 2023
Merged

feat(codefix): create component signature interface for TOC #1278

merged 9 commits into from
Oct 2, 2023

Conversation

wondersloth
Copy link
Contributor

@wondersloth wondersloth commented Sep 18, 2023 •
edited
Loading

  • This creates an interface for a TOC, so that we can backfill missing arguments when running in drain mode.
  • Add optional property type property LikeTemplateOnlyComponentVariableDeclaration.
  • Chore, improves logic in getComponentSignatureNameFromTemplateOnlyComponent for non-happy path edge cases
  • Depends on feat(codefix): adds missing args to component signature for TOC #1276

@wondersloth wondersloth mentioned this pull request Sep 18, 2023
Merged
@wondersloth wondersloth mentioned this pull request Sep 18, 2023
Open
6 tasks
Base automatically changed from medwards/FEAT-toc-codefix to master September 26, 2023 18:08
@wondersloth wondersloth marked this pull request as ready for review September 26, 2023 20:51
@lynchbomb lynchbomb merged commit 3e9c370 into master Oct 2, 2023
2 checks passed
@lynchbomb lynchbomb deleted the medwards/FEAT-toc-stub branch October 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorio egorio egorio approved these changes

@lynchbomb lynchbomb lynchbomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wondersloth @egorio @lynchbomb