Img refactor #156
Merged
Img refactor #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes multiple props, the media container pattern, and simplifies markup BREAKING CHANGE: API has drastically changed as well as underlying markup of the component
benjag
commented
Nov 29, 2023
|
|
||
| /** Media for capturing attention and communicating messages */ | ||
| defineOptions({ | ||
| name: 'CdrImg', | ||
| inheritAttrs: false, |
There was a problem hiding this comment.
No longer necessary
benjag
commented
Nov 29, 2023
| ['soft', CdrRadiusSoft], | ||
| ['softer', CdrRadiusSofter], | ||
| ['round', CdrRadiusRound] | ||
| ]); |
There was a problem hiding this comment.
This map allows for a shorthand mapping of CdrToken values. The following computed property allows the component to accept the token or a custom radius.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors image to use CSS image properties
Breaking changes:
containerClasspropcoverpropmodifierpropcroppropradiusprop worksratioprop works