Set process exit code (See #7) #8

peripateticus · 2019-01-17T19:57:37Z

Set process exit code.
Add missing dependency
Add eslint/airbnb
eslint fixes.

- Set process exit code. - Add missing dependency - Add eslint/airbnb - eslint fixes.

peripateticus · 2019-01-17T19:59:33Z

core.js

+      console.log(data.toString());
+    });
+
+    cmd.on('exit', (code) => {


This is the fix.

See #7.

peripateticus · 2019-01-17T21:30:14Z

Ready for review.

See #7.

JoshCostanza

Tested and is blocking build now. extra comments in Vue have helped to flush out invalid prop aruguments

Set process exit code (See #7)

936bf6b

- Set process exit code. - Add missing dependency - Add eslint/airbnb - eslint fixes.

peripateticus requested review from JoshCostanza and a user January 17, 2019 19:57

peripateticus commented Jan 17, 2019

View reviewed changes

core.js

console.log(data.toString());

});

cmd.on('exit', (code) => {

Copy link

Member Author

peripateticus Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix.

Adding unit tests around exit codes.

0b869b4

See #7.

Simplifying exit code tests.

92b6c68

See #7.

JoshCostanza approved these changes Jan 18, 2019

View reviewed changes

peripateticus merged commit 2203ed9 into master Jan 18, 2019

peripateticus deleted the fix-set-return-code branch January 18, 2019 21:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set process exit code (See #7) #8

Set process exit code (See #7) #8

peripateticus commented Jan 17, 2019

peripateticus Jan 17, 2019

peripateticus commented Jan 17, 2019

JoshCostanza left a comment

Set process exit code (See #7) #8

Set process exit code (See #7) #8

Conversation

peripateticus commented Jan 17, 2019

peripateticus Jan 17, 2019

Choose a reason for hiding this comment

peripateticus commented Jan 17, 2019

JoshCostanza left a comment

Choose a reason for hiding this comment