Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some code cleanup #17

Merged
merged 1 commit into from
Mar 25, 2024
Merged

some code cleanup #17

merged 1 commit into from
Mar 25, 2024

Conversation

reiase
Copy link
Owner

@reiase reiase commented Mar 25, 2024

No description provided.

@reiase reiase force-pushed the feature/clean_up branch 2 times, most recently from 100486d to a6293f2 Compare March 25, 2024 06:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.38095% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 64.39%. Comparing base (e7902cf) to head (476738e).
Report is 2 commits behind head on master.

Files Patch % Lines
core/src/storage.rs 60.00% 10 Missing ⚠️
core/src/api.rs 90.74% 5 Missing ⚠️
core/src/value.rs 33.33% 2 Missing ⚠️
core/src/xxh.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   68.46%   64.39%   -4.07%     
==========================================
  Files          17       17              
  Lines        1579     1761     +182     
  Branches       78       78              
==========================================
+ Hits         1081     1134      +53     
- Misses        481      610     +129     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reiase reiase merged commit 424461f into master Mar 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants