Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register custom alias provided by the user if present #9

Merged
merged 2 commits into from Jan 24, 2023

Conversation

kpodsiad
Copy link
Contributor

fixes #8, although I'm not sure what exactly semantic of auto alias should be and if my fix is not breaking other things. Unit tests are passing but maybe it'll be worth to have scripted test to see if aliases are working?

Copy link
Owner

@reibitto reibitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah, that's definitely a mistake on my part when refactoring. Your fix here looks good to me. I'm not sure why I didn't have warnings as failures in this project. I'll have to fix that next.

I'm actually not sure how to write an integration test for sbt plugins and check its internal state, but I could at the very least add a test to make sure the sbt command in the data structure is correct. The only tests that currently exist test the rendering.

Thanks for the PR!

@reibitto reibitto merged commit fe9d928 into reibitto:master Jan 24, 2023
@kpodsiad
Copy link
Contributor Author

I'm actually not sure how to write an integration test for sbt plugins and check its internal state, but I could at the very least add a test to make sure the sbt command in the data structure is correct. The only tests that currently exist test the rendering.

I have some experience with scripted tests, I can take a look and try to write one. I think internal state doesn't need to be inspected, all what we need to check is if an alias invokes a command and doesn't result in error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aliases are not working after upgrading to 0.3.0
2 participants