-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to update Star Grain Preview Widget causes a crash #210
Comments
I've done some more testing and this issue actually impacts all grain preview graphs any time the cleanup function is called (presumably when updating the preview widget). |
I am not sure if this is still stopping you, but if it is the fix for me was: self.plot.lines.pop(0) with this one: self.plot.lines[0].remove() That being said probably fixing the versions in the |
I have this fix and updated+fixed dependency versions on the |
I have also pushed with my latest PR. Maybe if that one gets merged we are good on this front too. |
Editing the geometry of a star grain causes a crash with the following error:
0.0000 [LOG] Application started at 2023-02-25T17:09:27.724259 0.3590 [LOG] Starting new motor file 0.3590 [LOG] Opening window QLayout: Attempting to add QLayout "" to MotorEditor "motorEditor", which already has a layout 0.4840 [LOG] Window opened 63.5630 [ERR] Traceback (most recent call last): 63.5630 [ERR] File "C:\Users\drago\Documents\GitHub\openMotor\uilib\widgets\grainPreviewWidget.py", line 50, in updateView 63.5630 [ERR] self.ui.tabRegression.cleanup() 63.5630 [ERR] File "C:\Users\drago\Documents\GitHub\openMotor\uilib\widgets\grainPreviewGraph.py", line 41, in cleanup 63.5630 [ERR] self.plot.lines.pop(0) 63.5630 [ERR] AttributeError: 'ArtistList' object has no attribute 'pop' 63.5630 [ERR] 63.5630 [LOG] Application closed due to exception.
Just prior to the crash the file looks like this:
![image](https://user-images.githubusercontent.com/4712964/221385509-d61f25b6-e411-41f6-b4a7-da1991644945.png)
Attempting to edit the "Point Width" to 1.1 results in the crash. The value does not matter, as if 1.1 is entered initially, changing it to 1.0 will cause a crash.
This issue occurs both on the fix_tests branch and Release 0.5.0 on Windows (same computer), but not on Release 0.5.0 on Mac
An example of a file that can cause a crash is attached below.
star_crash.ric.txt
The text was updated successfully, but these errors were encountered: