Add wildcard permission (permission for all types) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insert that permission into new apps.
| data: { | ||
| createReindexPermission: { | ||
| ReindexPermission: { | ||
| id: permissionId, |
There was a problem hiding this comment.
This looks like a verbose check that doesn't really test all that much. You could simply do
assert.deepProperty(
permission,
'data.createReindexPermission.ReindexPermission.id'
);for the same effect and less noise.
|
All good @fson ? |
|
Yeah ship it |
freiksenet
added a commit
that referenced
this pull request
Sep 7, 2015
Add wildcard permission (permission for all types)
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert that permission into new apps.