Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove moc preprocessing in wxQT #15

Merged
merged 6 commits into from Jun 10, 2014
Merged

Remove moc preprocessing in wxQT #15

merged 6 commits into from Jun 10, 2014

Conversation

reingart
Copy link
Owner

Meta-object compiler should not be needed anymore as wxQT uses now new Qt5 syntax to connect QObject member (sender, signal, receiver, function):

connect(this, &QTabWidget::currentChanged, this, &wxQtTabWidget::currentChanged);

Changes:

  • use new connection syntax
  • Q_OBJECT, SIGNAL and SLOT macros removed
  • wxQt helpers (_qt.cpp) merged back to main wx sources (.cpp)
  • moc build rules removed (*.moc.cpp)

Complete discussion in wx-dev:

https://groups.google.com/d/msg/wx-dev/UpkJMnT3V2o/F9d-7_oR1JoJ

@reingart
Use wxQtEventSignalHandler for wxQtTabWidget helper (and move declara…
01a334b 
…tion to header)
@reingart
Remove Q_OBJECT macro for wxQT notebook to avoid vtable link-time err…
bbef1f9 
…or due no moc precompilation being used (not needed as not using slots)
@reingart
Unify wxQT helpers code (*_qt.cpp) inside main source files (*.cpp), …
4a7590d 
…some headers (*_qt.h) remains independent to avoid include problems (first stage to remove moc)
@reingart
Remove Q_OBJECT and Q_SLOTS from wxQT headers to avoid vtable linking…
bfdfdaa 
… issues (second stage to remove moc)
@reingart
Use new Qt5 syntax to connect signals to QObject's member functions i…
d49cf90 
…n wxQT, removing SLOT and SIGNAL macros (third stage to remove moc)
@reingart
Remove rule for Qt's moc precompiler as no longer needed
7bc660f
reingart added a commit that referenced this pull request Jun 10, 2014
@reingart
Merge pull request #15 from reingart/wxQT_no_moc_experimental
2bbacc3 
Wx qt no moc experimental
@reingart reingart merged commit 2bbacc3 into SOC2014_QT Jun 10, 2014
@reingart reingart added this to the wxQT enhancements milestone Jun 10, 2014
@reingart reingart changed the title Wx qt no moc experimental Remove moc preprocessing in wxQT Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
wxQT enhancements
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reingart