Comment up the DNS server so it is comprehensible by humans. #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya!
See https://stackoverflow.com/questions/43524492/nodemcu-udp-dns-request-format
Per this question, I've commented up the DNS server as-implemented so it's clear what RFC fields are set where in your code (in case someone ever wants to muck with them). I'm not sure whether nodemcu/lua will consume heap from the comments alone (no idea), so it may be worth either breaking out my comments into another file or stripping them as a preprocessing step when doing builds.
Happy holidays!