This repository has been archived by the owner on Jul 18, 2023. It is now read-only.
fix: stderr log lines getting squished together #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styles for span.log didn't apply when logs from stderr were wrapped inside a <div> with the color. This change would make it so that *every* log line would be wrappee with `span.log-line`, and the base styles are applied for this. If the logs are from stderr, an extra class `.stderr` would be added. Signed-off-by: shrihanDev <shrihankp198725@gmail.com>
Signed-off-by: shrihanDev <shrihankp198725@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles for span.log didn't apply when logs from stderr were wrapped inside a
<div style="color: red;">. This made the log distorted.This change would make it so that every log line would be wrapped with
span.log-line, and the base styles are applied for this. If the logs are from stderr, an extra class.stderrwould be added.