Fix test workflow #127
Merged
Fix test workflow #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merge jobs - Formatting
reitzig
commented
Mar 9, 2024
Comment on lines
+17
to
+18
| # TODO: re-enable test on MacOS once we have a way to install TeXlive | ||
| #- macos-latest |
There was a problem hiding this comment.
@koppor FYI: Action zauguin/install-texlive@v3 which you introduced doesn't seem to support macOS:
run echo "date=$(date -I)" >> $GITHUB_OUTPUT
date: option requires an argument -- I
IIRC, that's a standard problem you run into because macOS doesn't come with GNU tools by default.
Happy to accept a PR that re-introduces testing on macOS!
reitzig
commented
Mar 9, 2024
Comment on lines
49
to
53
| - name: Install MiKTeX | ||
| if: matrix.os == 'windows-latest' | ||
| run: | | ||
| choco install miktex --no-progress | ||
| echo "C:\Program Files\MiKTeX\miktex\bin\x64" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 |
There was a problem hiding this comment.
@koppor Wow, this is slow:
Do you have a way handy to use caching on this? Is there a dedicated action for choco you can recommend?
There was a problem hiding this comment.
Unfortunately, it's also brittle; I see failures sometimes. :/
There was a problem hiding this comment.
Caching for choco install is still an open issue: chocolatey/choco#2134. - And I am not aware of any other actions.
- Run workflow on target OS - Drop macOS; TeXlive install action doesn't work. - Un-freeze bundler.
reitzig
force-pushed
the
fix/test-workflow
branch
from
a6a3493
to
f12e210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.