Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect globally set SDKMAN_DIR #52

Closed
reitzig opened this issue Apr 3, 2024 · 0 comments · Fixed by #53
Closed

Respect globally set SDKMAN_DIR #52

reitzig opened this issue Apr 3, 2024 · 0 comments · Fixed by #53
Assignees
@reitzig
Labels
bug Something isn't working

Comments

@reitzig
Copy link
Owner

reitzig commented Apr 3, 2024 •
edited

Re #46:

I set SDKMAN_DIR globally, through environment.d with system. It should not be over-written by sdk.fish.

In my opinion, if both are defined, __sdkman_custom_dir should be preferred.

Labelling this as bug since, as @xtexChooser mentions, the original sdkman-init.sh does blindly trust and use SDKMAN_DIR. I think that's probably a bad idea, but well.
@reitzig reitzig added the bug Something isn't working label Apr 3, 2024
@reitzig reitzig self-assigned this Apr 3, 2024
reitzig added a commit that referenced this issue Apr 3, 2024
@reitzig
fix: Respect globally set SDKMAN_DIR
6aa7900 
Also, print a warning during shell startup
if a custom install path is set, but
SDKMAN! is not installed there.

fixes #52
@reitzig reitzig mentioned this issue Apr 3, 2024
Merged
reitzig added a commit that referenced this issue Apr 3, 2024
@reitzig
fix: Respect globally set SDKMAN_DIR
0c96a63 
Also, print a warning during shell startup
if a custom install path is set, but
SDKMAN! is not installed there.

fixes #52
reitzig added a commit that referenced this issue Apr 3, 2024
@reitzig
fix: Respect globally set SDKMAN_DIR
a0aa142 
Also, print a warning during shell startup
if a custom install path is set, but
SDKMAN! is not installed there.

fixes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reitzig reitzig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Respect globally set SDKMAN_DIR reitzig/sdkman-for-fish
1 participant
@reitzig