Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent block when sdk prompts #9

Closed
reitzig opened this issue Jul 14, 2018 · 1 comment
Closed

Silent block when sdk prompts #9

reitzig opened this issue Jul 14, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@reitzig
Copy link
Owner

reitzig commented Jul 14, 2018

When e.g. sdk upgrade prompts the user for input, fish-sdk does not show the prompt and silently locks.

Regression after #8, I think.

@reitzig
Copy link
Owner Author

reitzig commented Jul 14, 2018

So, using stdout of the bash process to pass data outside wasn't a good idea: not only did it mess with sdk being interactive, it also masked the status code (which I completely missed before).

With stdout/-err out of the picture, options are limited. I couldn't get named pipes to work, so it's temp files for now. Not nice, but it works.

Tests performed: those from #8, and in addition:

Status codes are passed correctly

> sdk version; echo $status

SDKMAN 5.6.5+313
0> sdk; echo $status

Usage: sdk <command> [candidate] [version]
<snip>
1

Interaction works

> sdk upgrade

Upgrade:
java (10.0.1-oracle, 8.0.171-oracle < 8.0.172-zulu)

Upgrade candidate(s) and set latest version(s) as default? (Y/n): n
> 

@reitzig reitzig closed this as completed Jul 14, 2018
@reitzig reitzig added the bug Something isn't working label Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant