Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage asciidoctor with bundler #1

Closed
wants to merge 1 commit into from

Conversation

peaceiris
Copy link

@peaceiris peaceiris commented May 27, 2020

I enhanced the workflow for fast execution!

Issue: peaceiris/actions-hugo#342
ruby/setup-ruby: https://github.com/ruby/setup-ruby
bundle command: https://bundler.io/

Actions log (Completed in 12s) : https://github.com/peaceiris/today-i-learned/runs/711724694?check_suite_focus=true

@reitzig
Copy link
Owner

reitzig commented May 27, 2020

Love the "magic" of the deploy action so that it tests the build but doesn't deploy on non-master branches! Didn't realize that was the case, thanks!

@reitzig
Copy link
Owner

reitzig commented May 29, 2020

@peaceiris, what do you think of actions-asciidoctor instead? 😬

Unfortunately, while that form of asciidoctor hack seems to work, here it fails:

fork/exec /home/runner/work/today-i-learned/today-i-learned/actions_asciidoctor/asciidoctor: exec format error

@reitzig reitzig added the enhancement New feature or request label May 29, 2020
@reitzig reitzig force-pushed the master branch 5 times, most recently from df72bb1 to 0c6c3d9 Compare May 29, 2020 11:26
@peaceiris
Copy link
Author

@reitzig
Copy link
Owner

reitzig commented May 29, 2020

Good alternative, thanks!

I'll stick to the action for now (and hope for future simplications regarding ruby setup).

Cheers!

@reitzig reitzig closed this May 29, 2020
@peaceiris peaceiris deleted the peaceiris-patch-1 branch May 29, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants