Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash an indicator for fullscreen #129

Open
paxperscientiam opened this issue Jul 16, 2017 · 12 comments
Open

Flash an indicator for fullscreen #129

paxperscientiam opened this issue Jul 16, 2017 · 12 comments

Comments

@paxperscientiam
Copy link
Collaborator

When fullscreen is possible, a message should flash or otherwise indicate to user that the enter key will toggle fullscreen mode.

@marekdedic
Copy link
Owner

This opens a pandora's box called internationalization...

@rejas
Copy link
Contributor

rejas commented May 12, 2018

Good point @GenaBitu. Also, most browsers already show some message when fullscreen is triggered. So I am closing this issue.

@rejas rejas closed this as completed May 12, 2018
@marekdedic
Copy link
Owner

Oh, I don't think it was meant as a message when fullscreen is triggered - I think it was meant as a message kind of like "You can press Enter to enter fullscreen" when the lightbox is opened, because otherwise most user won't know about the option to do so.

@rejas
Copy link
Contributor

rejas commented May 12, 2018

Aaaah, correct... Maybe an icon would suffice? But where to put it?

@rejas rejas reopened this May 12, 2018
@marekdedic
Copy link
Owner

Oh, I don't know about an icon, but maybe it could work if done well. I was kind of imagining something like a floating caption in the bottom right corner that disappears after n seconds...

@rejas
Copy link
Contributor

rejas commented Jun 4, 2018

Right now I have other projects to focus on so I leave this issue open but wont do it myself.
If somebody comes up with a good mockup, I'd reconsider this (dont do a PR before a design/idea is formulated). But normally your page should show this hint and not the library.

@paxperscientiam
Copy link
Collaborator Author

paxperscientiam commented Jun 5, 2018 via email

@rejas
Copy link
Contributor

rejas commented Jun 6, 2018

Well, there are icons for fullscreen indeed but those are for clicking on it, not for signalling "hey, press enter to go fullscreen"
And showing two icons sidebyside (icon_fullscreen)(icon_enter_key) seems convoluted to me....

@marekdedic
Copy link
Owner

Ok, why not go the simple route and instead of a fullscreen hint add a fullscreen button?

@rejas
Copy link
Contributor

rejas commented Jun 14, 2018

Where would you put it in attached image?
screenshot-2018-6-14 imagelightbox

@marekdedic
Copy link
Owner

marekdedic commented Jun 14, 2018

My idea would be either in the bottom right of the image or in the bottom right of the screen. (That's purely subjective though...) Also I think the idea of the button disappearing after some timeout might also make sense here (especially if the button would be over the image...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants