-
Notifications
You must be signed in to change notification settings - Fork 38
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash an indicator for fullscreen #129
Comments
This opens a pandora's box called internationalization... |
Good point @GenaBitu. Also, most browsers already show some message when fullscreen is triggered. So I am closing this issue. |
Oh, I don't think it was meant as a message when fullscreen is triggered - I think it was meant as a message kind of like "You can press Enter to enter fullscreen" when the lightbox is opened, because otherwise most user won't know about the option to do so. |
Aaaah, correct... Maybe an icon would suffice? But where to put it? |
Oh, I don't know about an icon, but maybe it could work if done well. I was kind of imagining something like a floating caption in the bottom right corner that disappears after |
Right now I have other projects to focus on so I leave this issue open but wont do it myself. |
I'm on the, but IIRC there is a pretty widely accepted icon for indicating
fullscreen
…On Mon, Jun 4, 2018, 5:15 AM Veeck ***@***.***> wrote:
Right now I have other projects to focus on so I leave this issue open but
wont do it myself.
If somebody comes up with a good mockup, I'd reconsider this (dont do a PR
before a design/idea is formulated). But normally your page should show
this hint and not the library.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHMMnybhLct0GSYS9Zwj9OiIpyRfOorMks5t5PqngaJpZM4OZW6G>
.
|
Well, there are icons for fullscreen indeed but those are for clicking on it, not for signalling "hey, press enter to go fullscreen" |
Ok, why not go the simple route and instead of a fullscreen hint add a fullscreen button? |
My idea would be either in the bottom right of the image or in the bottom right of the screen. (That's purely subjective though...) Also I think the idea of the button disappearing after some timeout might also make sense here (especially if the button would be over the image...) |
When fullscreen is possible, a message should flash or otherwise indicate to user that the
enter
key will toggle fullscreen mode.The text was updated successfully, but these errors were encountered: