New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add f-presence
, f-presence-directory
, f-presence-file
, f-presence-symlink
, and f-presence-readable
#118
Conversation
Also, I'm not quite sure how the |
Hello, thank you for your PR! I would like some additional changes before merging. First, could you add a Secondly, as you mentioned it, there is no commit for the shortdoc file. For this, you can edit the (f-presence
:noeval (f-presence-file "/path/to/existing/path")
:result "/path/to/existing/path"
:noeval (f-presence-file "/path/to/non/existing/path")
:result nil) |
I would also like you to modify |
Bah, humbug; the commit got slaughtered. Otherwise, is this better? I didn't quite understand the Sorry for the delay, though; had a final exam! 😅 |
This PR seems almost good to go, I’d just like you to port the changes This is because the
No worries, same here! |
Hope you did well! 😸 Could you tell me what I missed? I thought I covered everything, already? |
You’re actually good with the REAMDE, I don’t know why Github displayed the diff of an older commit. I tried to run the tests on my machine, but quite a few of them fail. At first glance, it seems for instance you forgot to set a list as one, and you inverted the arguments of |
Ah, quick note: I rebased, and the Cask file seems fine, but running |
Did you install the cask dependencies with
The (f-touch "file.txt")
(f-symlink "symlink" "file.txt") Which tries to overwrite |
Hello! Sorry for the delay! Difficult uni course and all that! 😅 I also didn't realize I hadn't replied! Everything seems to be in working order now! |
Hi, thanks for updating the PR!
Don’t sweat it, I’ve been there too 😄 It seems like there is still a rebase conflict with Also, there’s no need to update the It otherwise looks fine to me! |
Interesting... Could you explain what the rebase actually did? I saw that the files from your master and my branch seem to have been the same either way? Why didn't pulling work in this case? Sorry, still relatively new to git. 😅 |
There are unfortunately quite a few changes between your branch and the master branch, you can see it by going on the Files changed tab of this PR. To properly rebase your branch, you need to first make sure whether you have this repository in your remotes or not, you can check it with for remote in $(git remote); do
echo $remote: $(git remote get-url $remote)
done If you don’t have a remote pointing to this repository, you can add it with Let’s say you have the remote
In order to properly synchronize your master branch (local and remote) with this repository’s, you can pull and rebase your local repository on this repository’s branch. This can be done by checking out your master branch with |
... What just happened? Did I just undo all my work? Good thing I have a backup! 😹 Should I just apply the changes directly to a new fork off the master branch here? |
Add functions to return
path
whenpath
exists, is a file, is a directory, is a symlink, or is readable, similar tos-presence
from Magnar'ss.el
.This should be useful in situations such as
(cond)
, where you might want to see if a file, directory, symlink, etc. exists before returning it, all in one go.