Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & merge from PM's JSView Revive #3

Open
1 of 5 tasks
TPS opened this issue Feb 28, 2017 · 11 comments
Open
1 of 5 tasks

Update & merge from PM's JSView Revive #3

TPS opened this issue Feb 28, 2017 · 11 comments

Comments

@TPS
Copy link
Collaborator

TPS commented Feb 28, 2017

https://addons.palemoon.org/extensions/jsview-revive/

To Do:

  • Probably should be done to a branch 1st, & then PR'ed. (Looks to have had more than just a little extra work done for PM.)
  • Find a way to CC "csdev"
  • Find a way to credit/CC "Philip Chee"
  • Find a way to credit/CC "Ron Beckman (Pale Moon - @tmtisfree)"
  • Don't forget to check whether any removed legacy Ff/SM compatibility can/should be restored
@TPS
Copy link
Collaborator Author

TPS commented Jun 29, 2017

@tmtisfree Is all of the above correctly about yourself?

TPS added a commit that referenced this issue Jun 29, 2017
@tmtisfree
Copy link
Collaborator

Yes.

@TPS
Copy link
Collaborator Author

TPS commented Jun 30, 2017

@tmtisfree Wow, you're tough to track down! Are you interested in keeping an open development repo of JSView Revive on GitHub, either here (as I invited earlier) or under yourself? I'll happily give you whatever rights you want here, if that's your wish.

@tmtisfree
Copy link
Collaborator

Sorry for not responding on the PM forum. The JSView code is not online anywhere and I don't plan to develop it further. So you can get the latest code from the Pale Moon repository, update here from it and take over the development if you wish.

Some credentials are needed to update the Pale Moon repository with a new version. I can check with the PM staff to know if I can share them with you or I you need new ones.

Is that OK?

(Note that I plan to travel a lot in the next 2 months, so be patient.)

@TPS
Copy link
Collaborator Author

TPS commented Jun 30, 2017

The purpose of this rejuvenate repo is precisely that, so no worries. I myself am not a dev, but am willing to maintain the code's availability, so actual devs can contribute in a public manner.

So, giving me PM credentials will be counterproductive. Hang on to them somewhere safe, &, next time someone wants to update the XPI, we'll request the PM devs then.

@TPS TPS removed the help wanted label Jun 30, 2017
@Mottie
Copy link

Mottie commented Jun 30, 2017

I'm not trying to offend anyone, but this repository has an older version (v2.0.8) of JSView Revive - the current is v2.1.8.

Firefox will soon be using WebExtensions exclusively, so the Firefox version in this repository will soon be outdated. It might have been better to fork nekman's port to Chrome here since Firefox's WebExtensions will now work with that same code.

I don't know anything about the Pale Moon browser, so I'm not sure if it is also being updated to use WebExtensions. Just to clarify, is this repository meant to target Firefox or Pale Moon, or both?

@TPS
Copy link
Collaborator Author

TPS commented Jun 30, 2017

Actually, @Mottie, this repo has the last version I could find of JSView that I could find before it was abandoned/discontinued/removed, before the Revive edition existed. 😁

The purpose of this issue is to update to the latest (last?) Revive edition, & the preceeding discussion is preparatory for the subissues in OP. But feel free to submit PR to speed up progress — the rate I'm going, 2017 2117 may not see me land this. 🤷‍♂️

This repo is exclusively for the XPI version, per terms of https://github.com/rejuvenate/rejuvenate. Other versions are likely to be more religiously maintained than this, & this serves those of us who don't wish WebExtensions on our Ff-related browser(s) — like Pale Moon.

@tmtisfree
Copy link
Collaborator

This add-on had never really been either abandoned nor discontinued, it had had a life between v2.0.8 and when I took it over (v2.1.2). Please see the release notes from the Revive version.

@TPS
Copy link
Collaborator Author

TPS commented Nov 6, 2017

@tmtisfree I really can't find those notes.… Are you the original author csdev, as well⁉️

@tmtisfree
Copy link
Collaborator

No, I am TMTisFree ;)

Versions are listed in the (also attached) file named "mod-notes.txt" in the Revive version.

mod-notes.txt

@TPS
Copy link
Collaborator Author

TPS commented Nov 7, 2017

Ahh, I see it: That means I'm gonna hafta find a way to credit "Philip Chee." Anyone got a GitHub handle?

@TPS TPS removed their assignment Apr 29, 2018
@TPS TPS pinned this issue Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@Mottie @TPS @tmtisfree and others