Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method is register #10

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Method is register #10

merged 5 commits into from
Mar 19, 2020

Conversation

gpibarra
Copy link
Contributor

No description provided.

@themisir
Copy link

@mehdok please approve and push to pub.dev as soon as possible, I need this feature in production 😟

client: FusedLocationProviderClient,
result: Result?) {
if (IsolateHolderService?.isRunning) {
Log.d("BackgroundLocatorPlugin", "Check Locator service: running")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove log.

Log.d("BackgroundLocatorPlugin", "Check Locator service: running")
result?.success(true)
} else {
Log.d("BackgroundLocatorPlugin", "Check Locator service: not running")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove log.

@@ -151,6 +152,20 @@ class BackgroundLocatorPlugin()
stopIsolateService(context)
}

@JvmStatic
private fun isRegisterLocator(context: Context,
client: FusedLocationProviderClient,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for client

@mehdok mehdok merged commit 8d06f2d into rekabhq:master Mar 19, 2020
srmncnk pushed a commit to srmncnk/background_locator that referenced this pull request Sep 7, 2022
Fixing the locator so it still works after an app crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants