Export stringToGuid and shorten it a bit. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2019 17:12
This just exports 'stringToGuid' so that it can be used from a caller. I was reading string representation of uuids and needed to feed them into a guid for gpt.
This just uses stringconv.ParseUint to shorten the stringToGuid method.
|
Hello smoser. I'm OK to do StringToGuid public if you need in your project project. It have right to exist if it first version - for simpler write first time. |
|
On Sat, Feb 9, 2019, 12:37 PM Timofey Koolin ***@***.***> wrote:
Hello smoser.
I'm OK to do StringToGuid public if you need in your project project.
But I'm against changing body of function:
convert every char to string, then parse string - is very extensive
solution.
I can have right to exist if it first version - for simpler write first
time.
But I don't see reason to change fast function to slower.
Yeah, that's fine with me.
Thanks
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AABJsaIyCRCHkcGQhopuJ4KuvoaMw_0-ks5vLwdAgaJpZM4ax3Bn>
.
|
|
I make function public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.