Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fuse to be disabled #11

Closed
wants to merge 1 commit into from
Closed

Allow fuse to be disabled #11

wants to merge 1 commit into from

Conversation

whitty
Copy link

@whitty whitty commented Nov 12, 2015

To relax requirements on external packages

To relax requirements on external packages
@relan
Copy link
Owner

relan commented Nov 12, 2015

Thanks for the proposition! I definitely like the idea of modularity. But things are not that easy. Slightly filtered versions of Makefile.am and configure.ac are used in fuse-exfat and exfat-utils packages I publish on each release. I see three options here.

  1. Continue using a script that converts generic Makefile.am and configure.ac into package-specific versions.
  2. Modify Makefile.am and configure.ac so that do the right things depending on the package they are put into. E.g. disable FUSE dependency if there is no fuse subdirectory.
  3. Unite fuse-exfat and exfat-utils into a single package. Not sure whether packages maintainers will be happy with this.

What do you think?

@whitty
Copy link
Author

whitty commented Dec 7, 2015

Hi - I didn't have the need to split the packaging you have.

Is there any background I can follow up with to understand what you do - ie what steps to you follow to generate a release today.

I'm sure we can work something out that doesn't involve 3.

@relan
Copy link
Owner

relan commented Dec 8, 2015

Currently it's an ugly and fragile script (in the form of a makefile) that generates tarballs:

all:
    # fuse-exfat prepare
    grep -vwE '(git|autoconf|automake|autoreconf|cd exfat)' README.md > README
    git checkout configure.ac Makefile.am
    # fuse-exfat
    grep -wvE 'dump/Makefile|fsck/Makefile|label/Makefile|mkfs/Makefile' configure.ac > configure.ac.tmp
    sed -e 's/\[exfat\]/[fuse-exfat]/' -i configure.ac.tmp
    grep -wv SUBDIRS Makefile.am > Makefile.am.tmp
    echo 'SUBDIRS = libexfat fuse' >> Makefile.am.tmp
    # fuse-exfat complete
    mv configure.ac.tmp configure.ac
    mv Makefile.am.tmp Makefile.am
    autoreconf -i
    ./configure --prefix=/usr
    make distcheck
    # fuse-exfat prepare
    git checkout configure.ac Makefile.am
    # exfat-utils
    grep -wv 'fuse' configure.ac > configure.ac.tmp
    sed -e 's/\[exfat\]/[exfat-utils]/' -i configure.ac.tmp
    grep -wv SUBDIRS Makefile.am > Makefile.am.tmp
    echo 'SUBDIRS = libexfat dump fsck label mkfs' >> Makefile.am.tmp
    # exfat-utils complete
    mv configure.ac.tmp configure.ac
    mv Makefile.am.tmp Makefile.am
    autoreconf -i
    ./configure --prefix=/usr
    make distcheck
    git checkout configure.ac Makefile.am
    rm README

.PHONY: all

Ideas on how to improve this workflow are very welcome.

@ahkok
Copy link

ahkok commented Oct 14, 2019

It appears that building without libublio and fuse causes the fuse parts not to be built. Enough to close this now?

@ahkok
Copy link

ahkok commented Oct 14, 2019

NVM this was split entirely... PLZ close this bug :)

@whitty whitty closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants