Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exfat: support to build some exfat tools on Android. #53

Merged
merged 1 commit into from
Mar 6, 2017
Merged

exfat: support to build some exfat tools on Android. #53

merged 1 commit into from
Mar 6, 2017

Conversation

leeminghao
Copy link
Contributor

Now, add support to build mkexfatfs, exfatfsck, dumpexfat and exfatlabel

Change-Id: I9856f087157fde528e999dab316ede1662ba5b67
Signed-off-by: liminghao liminghao@xiaomi.com

Now, add support to build mkexfatfs, exfatfsck, dumpexfat and exfatlabel

Change-Id: I9856f087157fde528e999dab316ede1662ba5b67
Signed-off-by: liminghao <liminghao@xiaomi.com>
@relan relan changed the base branch from master to android March 6, 2017 07:21
@relan relan merged commit b2d909a into relan:android Mar 6, 2017
@relan
Copy link
Owner

relan commented Mar 6, 2017

Great! I've created a feature branch android, that will eventually merge into develop and master.

Is there anything else related to Android support that needs to be changed? E.g. here are some modifications by LineageOS:

@leeminghao
Copy link
Contributor Author

I'm sorry! For Android, the change "Handle 64-bit offsets correctly on Android" is not neccessary, because the bionic will automatic select to lseek/pread/pwrite. We just need control __USE_FILE_OFFSET64 according to _FILE_OFFSET_BITS defined into config.h

#if defined(__USE_FILE_OFFSET64)
163extern int truncate(const char *, off_t) __RENAME(truncate64);
164extern off_t lseek(int, off_t, int) __RENAME(lseek64);
165extern ssize_t pread(int, void *, size_t, off_t) __RENAME(pread64);
166extern ssize_t pwrite(int, const void *, size_t, off_t) __RENAME(pwrite64);
167extern int ftruncate(int, off_t) __RENAME(ftruncate64);
168#else
169extern int truncate(const char *, off_t);
170extern off_t lseek(int, off_t, int);
171extern ssize_t pread(int, void *, size_t, off_t);
172extern ssize_t pwrite(int, const void *, size_t, off_t);
173extern int ftruncate(int, off_t);
174#endif

@relan
Copy link
Owner

relan commented Mar 6, 2017

OK.

Feel free to submit any other changes you would like to upstream.

@relan
Copy link
Owner

relan commented Mar 13, 2017

@leeminghao, do you mind my changing the license of Android.mk from Apache to GPLv2+? The whole project is under GPL, so it makes little sense to use a different license for a makefile.

@leeminghao
Copy link
Contributor Author

I accept to change the license to GPLv2+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants