fix notification bug during incoming data call #1
Conversation
| postNotification(null); | ||
| notifyReceivedBackgroundToJS(); |
There was a problem hiding this comment.
Don't we still need to call notifyReceivedBackgroundToJS()? Omitting this may be why you cannot start a call from the iOS native contact app (as you mentioned on the status meeting this morning).
There was a problem hiding this comment.
Keeping notifyReceivedBackgroundToJS() does not solve the outgoing call issue from the native call app. In fact, I've installed old builds, and it seems that this issue is not new.
So I'm trying to figure out, wether it is caused by a change we've made earlier, or it is caused by an Android/Samsung update..
There was a problem hiding this comment.
Does the app still receive registerNotificationReceivedBackground events (in phon-push-notifications/attachEvents.android.js) without this?
There was a problem hiding this comment.
idk, I only end-to-end tested and incoming data call worked from dead state.. But I try to check log and and find out..
There was a problem hiding this comment.
If I comment out the registerNotificationReceivedBackground handler, phone still receives incoming data calls, but with no sound 🤷🏽♂️
There was a problem hiding this comment.
Ok, I guess we can live without background notifications. AFAICT we do not consume push/RECEIVED_BACKGROUND anywhere. But I don't think this change is suitable for an upstream PR.
| postNotification(null); | ||
| notifyReceivedBackgroundToJS(); |
There was a problem hiding this comment.
Ok, I guess we can live without background notifications. AFAICT we do not consume push/RECEIVED_BACKGROUND anywhere. But I don't think this change is suitable for an upstream PR.
When getting incoming data call, mobile freezes. User cannot receive or reject call.
Only way to get rid of call is to force kill app from settings.
When logging we found this fatal exception:
Trying this approach fixes the bug:
welldone-software#5