Remove (int) Cast in Attributes

[abilson]

This is minor, but it's a pain to cast enums in the attributes. Could we simply change the attribute definition to accept the enum instead of int?

Attribute Definition Before:
public RelativityObjectFieldAttribute(string fieldGuid, int fieldType)

Attribute Definition After:
public RelativityObjectFieldAttribute(string fieldGuid, Gravity.Base.RdoFieldType fieldType)

Attribute Implementation Before:
[RelativityObjectField(guidString, (int)RdoFieldType.FixedLengthText, length)]

Attribute Implementation After:
[RelativityObjectField(guidString, RdoFieldType.FixedLengthText, length)]

[ggachevski]

@abilson, this one has been chasing us for quite some time BIGly and we have not been able to run away from it, at least not in the form it is right now. The reason we do the casts is because under the hood we consider more integer values for conversion. We have two more types of properties. Here is a sample from SqlDao conversion, where we define property for FieldTypeByteArray and FieldTypeCustomListInt:

case (int)RdoFieldType.SingleChoice: case (int)RdoFieldType.SingleObject: case SharedConstants.FieldTypeCustomListInt: case SharedConstants.FieldTypeByteArray:

The solution here is to get rid of the RdoFieldType and define a Gravity-specific enum, yes, or to override it somehow to only contain enums and not have to cast. We just haven't had the time to do this, but I will tag it down on our progress pipeline to be implemented soon.

[Arithmomaniac]

The FieldType enum is implemented multiple times, e.g. Relativity.Services, RSAPI. We're going to have to create our own local version - which we already have in RDOFieldType.