Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelativityObjectChildrenList has redundant parameter #41

Closed
Arithmomaniac opened this issue Feb 22, 2018 · 0 comments
Closed

RelativityObjectChildrenList has redundant parameter #41

Arithmomaniac opened this issue Feb 22, 2018 · 0 comments
Assignees
@Arithmomaniac
Labels
breaking change type/refactor
Milestone
0.5

Comments

@Arithmomaniac
Copy link
Collaborator

Note the following from the front page example:

[RelativityObjectChildrenList(typeof(RelatedPurchase))]
public IList<RelatedPurchase> RelatedPurchases { get; set; }

The type parameter typeof(RelatedPurchase) is redundant. It should just be inferred from whatever property the attribute is on.
@mrobustelli mrobustelli added this to the 1.0 milestone Apr 19, 2018
@Arithmomaniac Arithmomaniac self-assigned this Apr 19, 2018
Arithmomaniac pushed a commit that referenced this issue Apr 20, 2018
#41 Remove redundant RelativityObjectChildrenList parameter
549c6b7
Arithmomaniac pushed a commit to Arithmomaniac/Gravity that referenced this issue Apr 22, 2018
relativitydev#41 Remove redundant RelativityObjectChildrenList parameter
5d9e2b2
Arithmomaniac pushed a commit to Arithmomaniac/Gravity that referenced this issue Apr 22, 2018
relativitydev#41 Remove redundant RelativityObjectChildrenList parameter
5246bf9
@Arithmomaniac Arithmomaniac mentioned this issue Apr 24, 2018
Closed
@Arithmomaniac Arithmomaniac added status/progress Status: In Progress and removed status/progress Status: In Progress labels Apr 24, 2018
hhristov-tsd added a commit that referenced this issue Apr 30, 2018
@hhristov-tsd
Merge pull request #66 from Arithmomaniac/41_RemoveRedundantChildList…
ded0cf3 
…Parameter

#41 Remove redundant RelativityObjectChildrenList parameter
@Arithmomaniac Arithmomaniac removed status/progress Status: In Progress status/review Status: In Review labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arithmomaniac Arithmomaniac

Labels
breaking change type/refactor
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@Arithmomaniac @mrobustelli