Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round trip all records in spec/fixtures #7

Open
ronaldtse opened this issue May 14, 2024 · 1 comment
Open

Round trip all records in spec/fixtures #7

ronaldtse opened this issue May 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

Pending:

There is also an issue with a missing xmlns at the root <modsCollection> when you round-trip a file.

@ronaldtse ronaldtse added the bug Something isn't working label May 14, 2024
@ronaldtse
Copy link
Contributor Author

There are a number of files that are currently skipped due to the serialization order being wrong, however, changing the order of those elements will cause more failures since the order in the test dataset is inconsistent.

I also don't know how to ignore element order comparison when it happens to be insignificant.

# Skipping the following tests due to order swaps
# Swap of "place" and "publisher" orders
SWAPPED_PLACE_PUBLISHER = %w[
allrecords-MODS-991000030219708106
allrecords-MODS-991000030229708106
].freeze
# Swap of "topic" and "genre" orders
SWAPPED_TOPIC_GENRE = %w[
allrecords-MODS-991000083229708106
allrecords-MODS-991000085919708106
].freeze
# Swap of "geographic" and "topic" orders
SWAPPED_GEOGRAPHIC_TOPIC = %w[
allrecords-MODS-991000030349708106
allrecords-MODS-991000033559708106
allrecords-MODS-991000064369708106
allrecords-MODS-991000080319708106
allrecords-MODS-991000080799708106
allrecords-MODS-991000081439708106
allrecords-MODS-991000083229708106
allrecords-MODS-991000083259708106
allrecords-MODS-991000084859708106
allrecords-MODS-991000085149708106
allrecords-MODS-991000085239708106
allrecords-MODS-991000085749708106
allrecords-MODS-991000085919708106
allrecords-MODS-991000086099708106
allrecords-MODS-991000086889708106
allrecords-MODS-991000086969708106
allrecords-MODS-991000087889708106
allrecords-MODS-991000088849708106
allrecords-MODS-991000088859708106
allrecords-MODS-991000088869708106
allrecords-MODS-991000089819708106
allrecords-MODS-991000090749708106
allrecords-MODS-991000090819708106
allrecords-MODS-991000090969708106
allrecords-MODS-991000090979708106
allrecords-MODS-991000091029708106
allrecords-MODS-991000091039708106
allrecords-MODS-991000091419708106
allrecords-MODS-991000091449708106
allrecords-MODS-991000091599708106
allrecords-MODS-991000091609708106
allrecords-MODS-991000091619708106
allrecords-MODS-991000091639708106
allrecords-MODS-991000091709708106
allrecords-MODS-991000091729708106
].freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant