-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(URGENT) Crash on processing BSI bibliographic item when it does not have contact information, but only a URI #21
Comments
@opoudjis it means the contributor's contact is an array of # @param url [String, nil]
# @param contact [Array<RelatonBib::Address, RelatonBib::Contact>]
def initialize(url: nil, contact: [])
@uri = URI url if url
@contact = contact
end We need to fidn where the contributor is created and fix it. |
@opoudjis I don't have this error with relaton-iso v1.15.0, relaton-iso-bib v1.14.0, and relaton-bib v1.14.5
|
@andrew2net Reread the first line of the ticket:
You have not addressed my request. Specifically I am doing the following, and I require you to debug it so that it does not crash, which it is now doing:
I am needing to do this, because I am substituting elements of the bibitem with replacement elements. The contact encoding discrepancy is in RelatonBib::HashConverter : old: result of ret.to_hash
out: result of RelatonBib::HashConverter.hash_to_bib
When I do .to_xml on the result, contributor converts fine, because its contact is a RelatonBib::Contact object. But the copyright element crashes, because its contact is a raw hash, not a RelatonBib::Contact object. So RelatonBib::HashConverter.hash_to_bib needs to treat https://github.com/relaton/relaton-bib/blob/main/lib/relaton_bib/hash_converter.rb:
You need to add something like:
|
@opoudjis fixed in the relaton-bib v 1.14.6 |
bundle exec relaton fetch "BSI BS EN ISO 19650-2"
works fine, but when I fetch that document from within Metanorma, I'm getting:
The text was updated successfully, but these errors were encountered: