Add skipBatch to cacheConfig options
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `cacheConfig.skipBatch` is truthy, we skip batching for that request even when the batchMiddleware is present. This allows users to better control what requests are batched together.
|
Thanks 🙏 |
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cacheConfig.skipBatchis truthy, we skip batching for that request even when the batchMiddleware is present. This allows users to better control what requests are batched together.Use case:
We have a bunch of
QueryRenderers on the page at once. Some of those queries are very fast, but a couple of them are very slow. When they're all batched together those fast queries are now just as slow as the slowest query in the batch. This allows us to skip batching for those very fast queries so that user's get a snappier experience.Fixes #80
This is my first PR on this project so please let me know what I may have missed or what I can do to further help!