Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flow annotations #11

Closed
cpojer opened this issue Aug 20, 2015 · 5 comments
Closed

Add Flow annotations #11

cpojer opened this issue Aug 20, 2015 · 5 comments

Comments

@cpojer
Copy link
Contributor

cpojer commented Aug 20, 2015

I think this is the next big thing we should add to this repo. Relay is fully typed with Flow and we should make that a standard for library around Flow.

@devknoll
Copy link
Contributor

👍

@cpojer cpojer changed the title Add Flow annotations for 0.4 Add Flow annotations Aug 28, 2015
@cpojer cpojer closed this as completed Nov 18, 2015
@taion
Copy link
Member

taion commented Nov 18, 2015

Why close this? I can't claim that it's a high priority for me, but I'd like to use Flow at some point.

@cpojer
Copy link
Contributor Author

cpojer commented Nov 18, 2015

just figured no one is working on it and there is no point in keeping the issue around :) feel free to reopen.

@taion
Copy link
Member

taion commented Nov 18, 2015

AFAIK nobody's working on any of the issues on the repo right now :D

Gonna re-open this, thanks!

@taion taion reopened this Nov 18, 2015
@taion taion mentioned this issue Dec 31, 2015
3 tasks
@taion
Copy link
Member

taion commented Aug 3, 2016

I'm going to close this out again.

Unfortunately Relay doesn't actually ship its Flow definitions, so I have no good way of making sure that any type checks I add here are consistent with what Relay has.

I'll look at this again once the Flow ecosystem has a better story around packages that use Flow also shipping Flow type definitions, with an eye especially on how graphql/graphql-js#412 pans out.

@taion taion closed this as completed Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants