-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript 4.8 Support #223
Comments
hi @NickHeiner, thanks for reporting 👍 Could you create a minimal project with the error? It will be useful to verify the resolution of the issue :) |
I think the minimal repro is literally just "update this repo to TS 4.8 and see if it builds". I tried to do that myself, but I got this error on
|
I have tried and it builds. If you want to try too , you need to execute npm install --force |
I tried and it doesn't build. Here's the branch demonstrating it: https://github.com/relay-tools/relay-hooks/compare/master...NickHeiner:relay-hooks:nth/ts-4.8?expand=1.
|
you're right :D Now I have created a PR in draft where there are changes to the relay context and typescript dependency |
Today I was able to spend more time on this issue and I noticed that with typescript versions after 4.8.2 the problem is not present. if you download the repo and do yarn & yarn build of the example project you will see that there is no problem. If you change the version of typescript to 4.8.2 the problem occurs. In the meantime, I'm closing the issue but I'd like to have your feedback |
When I update my project to TS 4.8, I get this error:
This is potentially related to this part of the release notes: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#improved-intersection-reduction-union-compatibility-and-narrowing.
The text was updated successfully, but these errors were encountered: