Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RAMF): Require private address and support public address of recipient #254

Merged
merged 10 commits into from
Aug 9, 2022
Merged

fix(RAMF): Require private address and support public address of recipient #254

merged 10 commits into from
Aug 9, 2022

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Aug 7, 2022 •
edited
Loading

Part of relaycorp/relayverse#19, and JVM counterpart to relaycorp/relaynet-core-js#491.

  • Implement RecipientAddressing class
  • Reimplement RAMFMessage.recipient as a RecipientAddressing
  • Remove RAMFMessage.isRecipientAddressPrivate
  • Remove https:// prefix from Internet addresses
  • Rename "private address" -> "id"
  • Rename "public address" -> "internet address"
  • Rename "public gateway" -> "internet gateway"
  • Check compatibility with JS implementation

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 7, 2022
View reviewed changes
@gnarea gnarea changed the title replace format signature constant "Relaynet" with "Awala" fix(RAMF): Require private address and support public address of recipient Aug 7, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 7, 2022
View reviewed changes
@gnarea gnarea marked this pull request as draft August 7, 2022 13:44
@gnarea gnarea mentioned this pull request Aug 8, 2022
Closed
gnarea added a commit to relaycorp/relaynet-core-js that referenced this pull request Aug 9, 2022
@gnarea
fix(SignedData): Allow eContent to be OCTET-STRING of SEQUENCE
24eb3b2 
Which would actually be the correct way to represent RAMF messages, but PKI.js unfortunately generates an `OCTET-STRING` containing an `OCTET-STRING` containing a `SEQUENCE`.

This is needed in relaycorp/awala-jvm#254
@gnarea gnarea mentioned this pull request Aug 9, 2022
Merged
@gnarea gnarea marked this pull request as ready for review August 9, 2022 21:00
@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Aug 9, 2022
@kodiakhq kodiakhq bot merged commit eba1a68 into master Aug 9, 2022
@kodiakhq kodiakhq bot deleted the cross-gateway-comms branch August 9, 2022 21:00
kodiakhq bot pushed a commit to relaycorp/relaynet-core-js that referenced this pull request Aug 9, 2022
@gnarea
fix(SignedData): Allow eContent to be OCTET-STRING of SEQUENCE (#…
ac6e5de 
…502)

(When verifying `SignedData` values, not when producing them)

This is actually the correct way to represent RAMF messages, but PKI.js unfortunately generates an `OCTET-STRING` containing an `OCTET-STRING` containing a `SEQUENCE` (because PKI.js parses the `OCTET-STRINGS` eagerly). Bouncy Castle (used by the JVM lib) does the right thing but the JS lib fails to process such values -- hence this PR.

This is needed in relaycorp/awala-jvm#254
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This PR is included in version 1.65.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnarea gnarea mentioned this pull request Aug 17, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees
No one assigned
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gnarea