Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement parcel collection #37

Merged
merged 15 commits into from
Oct 17, 2020
Merged

feat: Implement parcel collection #37

merged 15 commits into from
Oct 17, 2020

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Oct 13, 2020

Fixes #6. Fixes #9

TODO:

  • Don't make incoming messages source abortable.

@gnarea gnarea self-assigned this Oct 13, 2020
@gnarea gnarea marked this pull request as ready for review October 17, 2020 10:16
@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Oct 17, 2020
@gnarea gnarea merged commit c65fc95 into master Oct 17, 2020
@gnarea gnarea deleted the parcel-collection branch October 17, 2020 10:58
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 17, 2020
* wip

* complete handshake implementation

* implement normal closure

* require nonce signers

* Refuse malformed parcel deliveries

* Implement breaking out of iterable

* implement streaming

* refactor

* work around Jest "feature"

* complete

* add JS doc

* make incoming messages not abortable

* Upgrade ws-mock to fix bug

* remove mock-socket dep

* Run CI on Nodejs 12 & 14 [skip ci] c65fc95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement parcel collection (as events) Implement parcel collection (as generator)
1 participant