add "function-required-argument" rule #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Dec 9, 2020
| 'use strict'; | ||
|
|
||
| const utils = require('./utils'); | ||
| const shouldLint = utils.shouldLint; |
|
@sullenor After discussing this issue with my colleagues, they pointed out that the proper fix for the issue should be implemented with the typing for We should double-check why flow didn't catch this. |
|
Ok, I double-checked with the team. We have that rule because flow cannot differentiate between undefined and not specified arguments. |
|
@alunyov thanks for checking and for providing clarity for the flow issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #106 issue.
This change adds new rule to check missing argument for
readInlineDatafunction call. Docs https://relay.dev/docs/en/graphql-in-relay#inlineAlso updates
.eslintrc.jsexample in readme.