-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation errors in action and no draft created but action reports success #1335
Comments
Delete your current draft, this most likely happened because you switched default branch. |
@jetersen We've always used master as the default branch and that hasn't changed. I'm the only person in the org with permission to make those changes and I wouldn't because we have lots of internal tooling built around master being the default branch. There is currently no draft release in this repo to delete. |
@jetersen We are about to make a new release for this repo. The PR was created a few minutes ago and then merged later. Looks like the PR creation triggered a new draft release created by "github-actions" user and the merge triggered a separate draft release created by "release-drafter" user |
You ought to only use GitHub Actions. The GitHub App is not recommended to use. |
I'm seeing odd behavior from configurations that have been working for many months across over a hundred repositories.
We have seen duplicate draft releases created, one by the "release-drafter" user and another by a "github-actions" user, both for the same version number. I have been deleting one of them and publishing the other, and then when we merge more PRs, there are duplicates again.
Then we saw a release deleted after it was published. There was a discrepancy in the version number when we looked at the releases. The latest release was v1.1.1 but we knew we had published a v1.1.2 (the tag exists and it was published to NPM, which can only happen when we publish a release). The newest draft release from release-drafter was showing as v1.1.2, so I simply updated the tag number and name of the release to reflect v1.1.3 and published it. The workflow ran again when the draft was published, which I don't understand - it's only configured to run on push to master and the 3 pull request types, opened, reopened, and synchronize - and it overwrote the published release with a new draft release.
This explains the issue with the missing release, but I don't understand why this action would be running when the draft gets updated from draft to published - the config shows it should not:
Digging into what's happening, I triggered the action to run with a new PR and noted several errors in the logs:
Even with these errors, the action reports that it is successful, and no draft release is created.
Then I looked back at older release drafter actions, and there are several errors shown in some of them, again with no error reported on the action:
The text was updated successfully, but these errors were encountered: