Duplicated/Incorrect PRs listed

[whyman]

Hi,

I am getting some random very old PRs linked, or incorrect IDs or something strange.

As you can see below "Fixture Upgrade" is duplicated and the 2nd one links to a random old PR.

Project is OSS: here is the config: https://github.com/gerbera/gerbera/blob/master/.github/release-drafter.yml

Please help!

---

[jetersen]

@TimonVS I believe the GraphQL is doing something unexpected

[TimonVS]

I think I see what's going on here, the duplicate PRs are coming from forks. I will create a PR to filter those out :)
Thanks for reporting!

[TimonVS]

I'm reopening this issue because the fix I created turned out to be wrong. I will work on a definitive fix.

[whyman]

Any news?

[TimonVS]

Hey @v00d00, I've thought out the following solution:

We change the query in lib/commits.js to the following:

...
                associatedPullRequests(first: 5) {
                  nodes {
+                   baseRepository {
+                     nameWithOwner
+                   }
                    url
                    title
                    number
                    author {
                      login
                    }
                    mergedAt
                    isCrossRepository
                    labels(first: 10) {
                      nodes {
                        name
                      }
                    }
...

Then we filter out all PRs where baseRepository.nameWithOwner is not equal to the name with owner of the repository we're generating the changelog for.

I think this should be the solution but I haven't tested it yet and there might still be some edge cases that I haven't thought of. I'm was also wondering if we should create an option for people to include PRs from forks in the changelog? Probably not though.

I've created a draft PR with the changes: #251. Though it doesn't include tests yet. If you're using the Actions version of Release Drafter you should be able to test it by changing the .github/main.workflow file:

workflow "Push" {
  on = "push"
  resolves = ["Draft Release"]
}

action "Draft Release" {
- uses = "toolmantim/release-drafter@v5.2.0"
+ uses = "TimonVS/release-drafter@fix/221"
  secrets = ["GITHUB_TOKEN"]
}

[whyman]

Unfortunately we use the "app" version.

[rnorth]

We've just noticed this problem over in testcontainers/testcontainers-java, with a PR from our repo into someone's fork ending up in our draft release notes. This is the PR that caused it, triggering an entry in our release draft like this:

Strangely I've been unable to reproduce it myself today, though.

@toolmantim is it possible that this has been fixed in the last couple of weeks?

[toolmantim]

Strange! I haven't released an update in quite a while @rnorth…

[jetersen]

@toolmantim The logic the draft PR #251 @TimonVS should solve the problem

[jetersen]

I'd like resume work adding a test.

[jetersen]

@rnorth Thanks for pointing to a PR, made it easier to recreate a test.

I'll see if I can land a release to the app tomorrow or at least this week 😅
Few more PRs that would be nice to land.